Reuse metric names in TopMetricsAggregator #116296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
not-napoleon
approved these changes
Nov 7, 2024
|
|
||
| Metrics(MetricValues[] values) { | ||
| this.values = values; | ||
| names = new ArrayList<>(values.length); | ||
| for (MetricValues value : values) { |
There was a problem hiding this comment.
I agree that the for loop is more readable here than the stream.
There was a problem hiding this comment.
And the stream was creating a list with initial size of 10 although we were adding only one element.
iverase
added
the
auto-backport
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Nov 7, 2024
This commit shares a unique instance between all InternalTopMetrics instances.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 7, 2024
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Nov 7, 2024
This commit shares a unique instance between all InternalTopMetrics instances.
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
This commit shares a unique instance between all InternalTopMetrics instances.
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
This commit shares a unique instance between all InternalTopMetrics instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in a heapdump that we are creating a new list of names for each new InternalTopMetrics created which seems wasteful as we can be creating thousand of those objects during an aggregation execution. This commit shares a unique instance between all InternalTopMetrics instances.