Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16] Handle status code 0 in S3 CMU response (#116212) #116231

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[8.16] Handle status code 0 in S3 CMU response (#116212) #116231

merged 1 commit into from
Nov 5, 2024

Conversation

DaveCTurner
Copy link
Contributor

Backports the following commits to 8.16:

@DaveCTurner @metadaddy
Handle status code 0 in S3 CMU response (elastic#116212)
bc21b5d 
A `CompleteMultipartUpload` action may fail after sending the `200 OK`
response line. In this case the response body describes the error, and
the SDK translates this situation to an exception with status code 0 but
with the `ErrorCode` string set appropriately. This commit enhances the
exception handling in `S3BlobContainer` to handle this possibility.

Closes elastic#102294

Co-authored-by: Pat Patterson <[email protected]>
@DaveCTurner DaveCTurner added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Nov 5, 2024
@elasticsearchmachine elasticsearchmachine mentioned this pull request Nov 5, 2024
Merged
@elasticsearchmachine elasticsearchmachine merged commit 2532b8c into elastic:8.16 Nov 5, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the backport/8.16/pr-116212 branch November 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.16.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveCTurner @elasticsearchmachine