Refactor ESQL CcsUtils #116121
Merged
Refactor ESQL CcsUtils #116121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quux00
added
>refactoring
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
smalyshev
reviewed
Nov 1, 2024
| for (FieldCapabilitiesFailure failure : failures) { | ||
| if (ExceptionsHelper.isRemoteUnavailableException(failure.getException())) { | ||
| for (String indexExpression : failure.getIndices()) { | ||
| if (indexExpression.indexOf(RemoteClusterAware.REMOTE_CLUSTER_INDEX_SEPARATOR) > 0) { |
There was a problem hiding this comment.
Are index expressions already parsed here? E.g. remote/index wildcards, etc.?
There was a problem hiding this comment.
Yes. It is called in IndexResolver after calling field-caps. It sifts through the FieldCapsResponse failure list.
This is not new code. I just moved this method out of IndexResolver into the utils method, as Costin had requested in my earlier PR.
smalyshev
approved these changes
Nov 1, 2024
💚 Backport successful
|
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Nov 2, 2024
Pure refactoring PR
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Nov 2, 2024
Pure refactoring PR
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Pure refactoring PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalized refactorings from closed PR https://github.com/elastic/elas…ticsearch/pull/115976
This is a pure refactoring PR. No new code has been added other than two new tests in
EsqlSessionCCSUtilsTests.java.