Tidy up ClusterStatsNodeRequest
#116036
Merged
Tidy up ClusterStatsNodeRequest
#116036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an `@UpdateForV9` on this class saying that it could be replaced with `TransportRequest.Empty`. But that was removed by elastic#109790, and all its non-test usages replaced by trivial implementations of `TransportRequest`. This change therefore just simplifies the class a bit and removes that annotation.
| @@ -320,11 +317,6 @@ public ClusterStatsNodeRequest(StreamInput in) throws IOException { | |||
| public Task createTask(long id, String type, String action, TaskId parentTaskId, Map<String, String> headers) { | |||
| return new CancellableTask(id, type, action, "", parentTaskId, headers); | |||
| } | |||
There was a problem hiding this comment.
Can we remove this override? The effect would be to have it return a plain Task instead of a CancellableTask. I don't know if that's safe / desirable. (The createActionContext method does expect to be passed a CancellableTask, if that's relevant.)
There was a problem hiding this comment.
No, this was added in #68676 as part of making this cancellable
PeteGillinElastic
added
:Data Management/Stats
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
approved these changes
Oct 31, 2024
| @@ -320,11 +317,6 @@ public ClusterStatsNodeRequest(StreamInput in) throws IOException { | |||
| public Task createTask(long id, String type, String action, TaskId parentTaskId, Map<String, String> headers) { | |||
| return new CancellableTask(id, type, action, "", parentTaskId, headers); | |||
| } | |||
There was a problem hiding this comment.
No, this was added in #68676 as part of making this cancellable
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
There was an `@UpdateForV9` on this class saying that it could be replaced with `TransportRequest.Empty`. But that was removed by elastic#109790, and all its non-test usages replaced by trivial implementations of `TransportRequest`. This change therefore just simplifies the class a bit and removes that annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an
@UpdateForV9on this class saying that it could be replaced withTransportRequest.Empty. But that was removed by #109790, and all its non-test usages replaced by trivial implementations ofTransportRequest. This change therefore just simplifies the class a bit and removes that annotation.