Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES|QL: Mute test for #116003 #116005

Merged
merged 1 commit into from
Oct 31, 2024
Merged

ES|QL: Mute test for #116003 #116005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions ...in/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/TelemetryIT.java
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a correct name to those tests, so we can mute them in the typical way (And as a general good practice too).
This test is quite small, so not really important anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'm merging it to unlock people, but I'll follow up with some improvements

Original file line number Diff line number Diff line change
Expand Up @@ -128,20 +128,22 @@ public static Iterable<Object[]> parameters() {
: Collections.emptyMap(),
Build.current().isSnapshot() ? Map.ofEntries(Map.entry("MAX", 1)) : Collections.emptyMap(),
Build.current().isSnapshot()
) },
new Object[] {
new Test(
"""
FROM idx
| EVAL ip = to_ip(host), x = to_string(host), y = to_string(host)
| INLINESTATS max(id)
""",
Build.current().isSnapshot() ? Map.of("FROM", 1, "EVAL", 1, "INLINESTATS", 1, "STATS", 1) : Collections.emptyMap(),
Build.current().isSnapshot()
? Map.ofEntries(Map.entry("MAX", 1), Map.entry("TO_IP", 1), Map.entry("TO_STRING", 2))
: Collections.emptyMap(),
Build.current().isSnapshot()
) }
// awaits fix for https://github.com/elastic/elasticsearch/issues/116003
// ,
// new Object[] {
// new Test(
// """
// FROM idx
// | EVAL ip = to_ip(host), x = to_string(host), y = to_string(host)
// | INLINESTATS max(id)
// """,
// Build.current().isSnapshot() ? Map.of("FROM", 1, "EVAL", 1, "INLINESTATS", 1, "STATS", 1) : Collections.emptyMap(),
// Build.current().isSnapshot()
// ? Map.ofEntries(Map.entry("MAX", 1), Map.entry("TO_IP", 1), Map.entry("TO_STRING", 2))
// : Collections.emptyMap(),
// Build.current().isSnapshot()
// ) }
);
}

Expand Down