Fix failing StatsSummaryTests.testEqualsAndHashCode tests. #115919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afoucret
added
>test-failure
elasticsearchmachine
added
needs:triage
afoucret
added
:Search/Search
elasticsearchmachine
added
Team:Search
|
Pinging @elastic/es-search (Team:Search) |
cbuescher
reviewed
Oct 30, 2024
| randomDoubles(randomIntBetween(0, 20)).forEach(stats1); | ||
| randomDoubles(randomIntBetween(0, 20)).forEach(stats2); | ||
| randomDoubles(randomIntBetween(1, 1000)).forEach(stats1); | ||
| randomDoubles(randomIntBetween(1, 1000)).forEach(stats2); |
There was a problem hiding this comment.
Would it make sense to even keep the random ranges non-overlapping in this case? Or is this overkill because picking the same amount of doubles and the same values is so unlikely?
There was a problem hiding this comment.
My assumption was indeed that the probability of having an equality with such a combination is lower than winning to the lottery twice the same month ....
Also, I did run the tests with -D tests.iters=1000000 to check the randomization
cbuescher
approved these changes
Oct 30, 2024
|
Closed in favor of #115922 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112439
Closes #112511
Description
The failure was due to a high probability (approximately every 400 runs) of adding 0 new items to both accumulators in the following code:
This led to both accumulators being equal when they were not expected to be.