-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double lookup failure on ESQL #115616
Fix double lookup failure on ESQL #115616
Conversation
Can someone help me assign some labels? |
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/physical/HashJoinExec.java
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, @jackpan123, nice find!
The fix looks good to me. We will not be able to close #111398 with this, though. Because we'd have to add tests to avoid regressions in the future - but more importantly because LOOKUP
is still under development and currently changing a lot, so that the corresponding tests are disabled right now.
@elasticsearchmachine test this please |
@elasticsearchmachine generate changelog |
@elasticsearchmachine test this please |
💚 Backport successful
|
Fix a bug in HashJoinExec.addedFields that caused multiple LOOKUPs in a query to fail.
Fix a bug in HashJoinExec.addedFields that caused multiple LOOKUPs in a query to fail. Co-authored-by: Jack Pan <[email protected]>
Fix a bug in HashJoinExec.addedFields that caused multiple LOOKUPs in a query to fail.
Fix a bug in HashJoinExec.addedFields that caused multiple LOOKUPs in a query to fail.
Fix double lookup failure on ESQL (Closes #111398 ).
I also try three times LOOKUP, it is fine, result like below: