Query refactoring: refactored LimitQueryBuilder and Parser and added test #11551
+90
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
force-pushed
the
feature/query-refactoring-limit
branch
from
2de8ade to
19cc62a
Compare
|
LGTM |
…test Split the parse method into a parsing and a query building part, adding serialization and hashCode(), equals() for better testing. Add basic unit test for Builder and Parser. Closes elastic#11551
cbuescher
force-pushed
the
feature/query-refactoring-limit
branch
from
19cc62a to
aadfd17
Compare
cbuescher
added a commit
that referenced
this pull request
Jun 9, 2015
Query refactoring: refactored LimitQueryBuilder and Parser and added test
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…test Split the parse method into a parsing and a query building part, adding serialization and hashCode(), equals() for better testing. Add basic unit test for Builder and Parser. Closes elastic#11551
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ring-limit Query refactoring: refactored LimitQueryBuilder and Parser and added test
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the parse method into a parsing and a query building part, adding serialization and hashCode(), equals() for better testing.
Add basic unit test for Builder and Parser.
PR goes agains query-refacoring feature branch.