Always flush response body in AbstractBlobContainerRetriesTestCase#sendIncompleteContent with JDK23 #115197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndIncompleteContent with JDK23
pxsalehi
added
>test
elasticsearchmachine
added
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
commented
Oct 21, 2024
| @@ -418,7 +418,9 @@ protected int sendIncompleteContent(HttpExchange exchange, byte[] bytes) throws | |||
| if (bytesToSend > 0) { | |||
| exchange.getResponseBody().write(bytes, rangeStart, bytesToSend); | |||
| } | |||
| if (randomBoolean()) { | |||
| if (randomBoolean() || Runtime.version().feature() >= 23) { | |||
There was a problem hiding this comment.
The "fix" should be only temporary and for a specific version, so I'd rather not always flush.
ywangd
approved these changes
Oct 21, 2024
Comment on lines
422
to
423
| // For now in JDK23 we need to always flush. See https://bugs.openjdk.org/browse/JDK-8331847. | ||
| // TODO: remove the JDK version check once that bug is fixed |
There was a problem hiding this comment.
It's not a bug but rather intended behaviour as an optimization if I understand the jdk issue correctly.
pxsalehi
added
auto-merge-without-approval
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Oct 21, 2024
…ndIncompleteContent with JDK23 (elastic#115197) Resolves elastic#115172
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Oct 21, 2024
…ndIncompleteContent with JDK23 (elastic#115197) Resolves elastic#115172
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Oct 23, 2024
…ndIncompleteContent with JDK23 (elastic#115197) Resolves elastic#115172
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 23, 2024
…ndIncompleteContent with JDK23 (#115197) (#115441) Resolves #115172 Co-authored-by: Pooya Salehi <[email protected]>
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
…ndIncompleteContent with JDK23 (elastic#115197) Resolves elastic#115172
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Oct 25, 2024
…ndIncompleteContent with JDK23 (elastic#115197) Resolves elastic#115172
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 25, 2024
…ndIncompleteContent with JDK23 (#115197) (#115680) Resolves #115172 Co-authored-by: Pooya Salehi <[email protected]>
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…ndIncompleteContent with JDK23 (elastic#115197) Resolves elastic#115172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #115172