Fix scale up for model allocations #115189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-elastic
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
jan-elastic
commented
Oct 21, 2024
| @@ -177,7 +177,7 @@ public boolean isEmpty() { | |||
| return anomalyDetectionTasks.isEmpty() | |||
| && snapshotUpgradeTasks.isEmpty() | |||
| && dataframeAnalyticsTasks.isEmpty() | |||
| && modelAssignments.values().stream().allMatch(assignment -> assignment.totalTargetAllocations() == 0); | |||
| && modelAssignments.values().stream().allMatch(assignment -> assignment.getTaskParams().getNumberOfAllocations() == 0); | |||
There was a problem hiding this comment.
This code is so confusing...
Anyway, assignment.totalTargetAllocations() is the number of allocations assigned to ML nodes, but if there are no nodes, there are no assigned allocations. assignment.getTaskParams().getNumberOfAllocations() is the number that's wanted.
I've also added a test for this.
davidkyle
approved these changes
Oct 21, 2024
| @@ -177,7 +177,7 @@ public boolean isEmpty() { | |||
| return anomalyDetectionTasks.isEmpty() | |||
| && snapshotUpgradeTasks.isEmpty() | |||
| && dataframeAnalyticsTasks.isEmpty() | |||
| && modelAssignments.values().stream().allMatch(assignment -> assignment.totalTargetAllocations() == 0); | |||
| && modelAssignments.values().stream().allMatch(assignment -> assignment.getTaskParams().getNumberOfAllocations() == 0); | |||
There was a problem hiding this comment.
Oh because if there are no ml nodes in the cluster assignment.totalTargetAllocations() == 0 even if assignment.getTaskParams().getNumberOfAllocations() > 0
jan-elastic
added a commit
that referenced
this pull request
Oct 21, 2024
jan-elastic
added a commit
that referenced
this pull request
Oct 21, 2024
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Oct 21, 2024
jan-elastic
added a commit
that referenced
this pull request
Oct 21, 2024
This was referenced Oct 21, 2024
jan-elastic
added a commit
that referenced
this pull request
Oct 21, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 21, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 21, 2024
saarikabhasi
added a commit
to elastic/kibana
that referenced
this pull request
Oct 22, 2024
## Summary Semantic text feature was disabled by default due to ML node unable to scale down. With the relevant [PR](elastic/elasticsearch#114323) & subsequent [fix](elastic/elasticsearch#115189) merged, ML node now auto scales when there is no activity. Therefore enabling semantic_text feature in es3. ### Testing instructions * start serverless instance * visit index management index details page -> mappings * Click Add field * Confirm `semantic_text` is shown in the field type form
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #114930