Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ESQL: Remove parent from FieldAttribute (#112881)" #115006

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

alex-spies
Copy link
Contributor

We need to revert #112881 because the previous transport version change wasn't backported to 8.x which needs fixing before this can finally be re-reverted.

@alex-spies alex-spies requested a review from thecoop October 17, 2024 12:58
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Oct 17, 2024
@alex-spies alex-spies merged commit 17ecb66 into elastic:main Oct 17, 2024
1 of 5 checks passed
@alex-spies
Copy link
Contributor Author

Merged ASAP in agreement with @thecoop to minimize the impact of the transport version change introduced by #112881.

alex-spies added a commit to alex-spies/elasticsearch that referenced this pull request Oct 17, 2024
elasticsearchmachine pushed a commit that referenced this pull request Oct 17, 2024
…#115007)

This reverts commit 17ecb66 and
reapplies #112881 once the
previous, non-backported transport version bump is dealt with.
alex-spies added a commit to alex-spies/elasticsearch that referenced this pull request Oct 17, 2024
…lastic#115006) (elastic#115007)

This reverts commit 17ecb66 and
reapplies elastic#112881 once the
previous, non-backported transport version bump is dealt with.
elasticsearchmachine pushed a commit that referenced this pull request Oct 17, 2024
…#115007) (#115035)

This reverts commit 17ecb66 and
reapplies #112881 once the
previous, non-backported transport version bump is dealt with.
lkts pushed a commit to lkts/elasticsearch that referenced this pull request Oct 18, 2024
…lastic#115006) (elastic#115007)

This reverts commit 17ecb66 and
reapplies elastic#112881 once the
previous, non-backported transport version bump is dealt with.
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
…lastic#115006) (elastic#115007)

This reverts commit 17ecb66 and
reapplies elastic#112881 once the
previous, non-backported transport version bump is dealt with.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
…lastic#115006) (elastic#115007)

This reverts commit 17ecb66 and
reapplies elastic#112881 once the
previous, non-backported transport version bump is dealt with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage Requires assignment of a team area label v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants