Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose cluster-state role mappings in APIs #114951
Expose cluster-state role mappings in APIs #114951
Changes from 35 commits
492837d
e8e6b05
78aaec2
d85b0d7
fe846e2
ba1531e
c63e6b0
02cb783
bf80273
e512004
5cab323
ba07fd2
08f8866
7ea2c1b
0242b70
4519ddd
5fb90de
363ab47
fd3cb5a
d79f473
8ae8492
9c2cba5
74c5674
4e77c66
c4c3a48
6ea654f
b7a676f
3c1064f
d9f15c4
eb8a9c5
d5be5a1
fc11ea1
01213ff
4be17a8
6f63d22
f0f2f98
8136af1
de5cf69
d5fee36
57f53aa
05f5f55
b1b8ad7
e7cd5a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport PRs fail compilation when the switch-case uses a qualified value; fixing it here to stay consistent with older branches. I did not dig into why this is not an issue for main (the PR merged and passed CI just fine).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that everything related to this fix is in one class, but I think it becomes a little hard to follow what's going on and it would be nice to not have to do a helper class if it's not needed. A short comment for each of the methods and putting them in the class where they're used would be better.
I also think the constants belong in
RoleMappingMetadata
since that class is already responsible for representing a role mapping as xcontent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair! I'll move the code into
RoleMappingMetadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do want to keep
copyWithNameInMetadata
andparseWithNameFromMetadata
in the same class though since they really only make sense together. Let me know if you have strong objections.