Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't normalize coordinates in GeoTileUtils #114929

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Oct 16, 2024

The main users of this class use as input latitudes and longitudes read from doc values. These coordinates are always on bounds so there is no point to try to normalise them, more over when this piece of code is in the hot path for aggregations.

@iverase iverase added >non-issue :Analytics/Geo Indexing, search aggregations of geo points and shapes v9.0.0 v8.17.0 labels Oct 16, 2024
@iverase iverase requested a review from craigtaverner October 16, 2024 16:44
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 16, 2024
@iverase
Copy link
Contributor Author

iverase commented Oct 16, 2024

@elasticmachine update branch

@iverase
Copy link
Contributor Author

iverase commented Oct 16, 2024

@elasticmachine update branch

Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iverase iverase added the auto-backport Automatically create backport pull requests when merged label Oct 17, 2024
@iverase iverase merged commit 1ebe1b3 into elastic:main Oct 17, 2024
16 checks passed
@iverase iverase deleted the mormalizeGeoTile branch October 17, 2024 14:59
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

iverase added a commit to iverase/elasticsearch that referenced this pull request Oct 17, 2024
The main users of this class use as input latitudes and longitudes read from doc values. These coordinates are always 
on bounds so there is no point to try to normalise them, more over when this piece of code is in the hot path for 
aggregations.
elasticsearchmachine pushed a commit that referenced this pull request Oct 17, 2024
The main users of this class use as input latitudes and longitudes read from doc values. These coordinates are always 
on bounds so there is no point to try to normalise them, more over when this piece of code is in the hot path for 
aggregations.
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
The main users of this class use as input latitudes and longitudes read from doc values. These coordinates are always 
on bounds so there is no point to try to normalise them, more over when this piece of code is in the hot path for 
aggregations.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
The main users of this class use as input latitudes and longitudes read from doc values. These coordinates are always 
on bounds so there is no point to try to normalise them, more over when this piece of code is in the hot path for 
aggregations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants