Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup BucketsAggregator#rewriteBuckets #114574

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Oct 11, 2024

The array is initialized with the flag clearOnResize set to true so we don't need to set the values to 0 again.

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 11, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase added the auto-backport Automatically create backport pull requests when merged label Nov 26, 2024
@iverase iverase merged commit bfe1aad into elastic:main Nov 26, 2024
16 checks passed
@iverase iverase deleted the BucketsAggregator-rewrite branch November 26, 2024 15:47
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

iverase added a commit to iverase/elasticsearch that referenced this pull request Nov 26, 2024
The array is initialized with the flag clearOnResize set to true so we don't need to set the values to 0 again.
elasticsearchmachine pushed a commit that referenced this pull request Nov 26, 2024
The array is initialized with the flag clearOnResize set to true so we don't need to set the values to 0 again.
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Nov 27, 2024
The array is initialized with the flag clearOnResize set to true so we don't need to set the values to 0 again.
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
The array is initialized with the flag clearOnResize set to true so we don't need to set the values to 0 again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants