Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin/otel-data] Add dynamic template for summary with min, max #113791

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[plugin/otel-data] Add dynamic template for summary with min, max #113791

merged 1 commit into from
Oct 1, 2024

Conversation

lahsivjar
Copy link
Contributor

Adds dynamic template mapping for summary metrics which have the min and max. Note that the dynamic template is currently not used and shipped to avoid version checks when we do use this mapping.

More context available at: https://github.com/elastic/opentelemetry-dev/pull/461#discussion_r1778172674

@lahsivjar lahsivjar requested a review from a team as a code owner September 30, 2024 12:08
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Sep 30, 2024
carsonip
carsonip approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, wonder if others have better ideas on the names (I don't); remember to backport to 8.16

@lahsivjar lahsivjar added Team:Data Management Meta label for data/management team auto-backport-and-merge v8.16.0 auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Sep 30, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:Data Management Meta label for data/management team label Sep 30, 2024
@lahsivjar lahsivjar added >enhancement Team:Data Management Meta label for data/management team labels Sep 30, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:Data Management Meta label for data/management team label Sep 30, 2024
@lahsivjar lahsivjar added :Data Management/Data streams Data streams and their lifecycles and removed auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge labels Oct 1, 2024
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team and removed needs:triage Requires assignment of a team area label labels Oct 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@lahsivjar lahsivjar added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged auto-backport-and-merge labels Oct 1, 2024
@lahsivjar lahsivjar merged commit 649acc4 into elastic:main Oct 1, 2024
15 of 16 checks passed
@lahsivjar lahsivjar deleted the agg_metric_dbl_minmax branch October 1, 2024 09:29
@lahsivjar lahsivjar removed the auto-backport Automatically create backport pull requests when merged label Oct 1, 2024
@lahsivjar lahsivjar mentioned this pull request Oct 1, 2024
Merged
@lahsivjar
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

lahsivjar added a commit to lahsivjar/elasticsearch that referenced this pull request Oct 1, 2024
@lahsivjar
[plugin/otel-data] Add dynamic template for summary with min, max (el…
1f46126 
…astic#113791)

(cherry picked from commit 649acc4)
elasticsearchmachine pushed a commit that referenced this pull request Oct 1, 2024
@lahsivjar
[plugin/otel-data] Add dynamic template for summary with min, max (#1…
0d702c3 
…13791) (#113849)

(cherry picked from commit 649acc4)
@gregkalapos gregkalapos mentioned this pull request Oct 1, 2024
Closed
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 4, 2024
@lahsivjar @matthewabbott
[plugin/otel-data] Add dynamic template for summary with min, max (el…
2624c35 
…astic#113791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsonip carsonip carsonip approved these changes

@felixbarny felixbarny felixbarny approved these changes

@gregkalapos gregkalapos gregkalapos approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Data streams Data streams and their lifecycles >enhancement Team:Data Management Meta label for data/management team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lahsivjar @elasticsearchmachine @gregkalapos @felixbarny @carsonip