Avoid implicit ML/transform master node timeouts #113536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today in the ML and Transform plugins we use `null` for timeouts related to persistent tasks, which means to use the implicit default timeout of 30s. As per elastic#107984 we want to eliminate all such uses of the implicit default timeout. This commit either moves to using the timeout from the associated transport request, if available, or else makes it explicit that we're using a hard-coded 30s timeout.
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
Sep 25, 2024
DaveCTurner
added
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 25, 2024
Today in the ML and Transform plugins we use `null` for timeouts related to persistent tasks, which means to use the implicit default timeout of 30s. As per elastic#107984 we want to eliminate all such uses of the implicit default timeout. This commit either moves to using the timeout from the associated transport request, if available, or else makes it explicit that we're using a hard-coded 30s timeout.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 25, 2024
Today in the ML and Transform plugins we use `null` for timeouts related to persistent tasks, which means to use the implicit default timeout of 30s. As per #107984 we want to eliminate all such uses of the implicit default timeout. This commit either moves to using the timeout from the associated transport request, if available, or else makes it explicit that we're using a hard-coded 30s timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today in the ML and Transform plugins we use
nullfor timeouts relatedto persistent tasks, which means to use the implicit default timeout of
30s. As per #107984 we want to eliminate all such uses of the implicit
default timeout. This commit either moves to using the timeout from the
associated transport request, if available, or else makes it explicit
that we're using a hard-coded 30s timeout.