[8.x] ESQL: Compute support for filtering ungrouped aggs (#112717) #112763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support to the compute engine for filtering which positions are
processed by ungrouping aggs. This should allow syntax like:
```
| STATS
success = COUNT(*) WHERE 200 <= response_code AND response_code < 300,
redirect = COUNT(*) WHERE 300 <= response_code AND response_code < 400,
client_err = COUNT(*) WHERE 400 <= response_code AND response_code < 500,
server_err = COUNT(*) WHERE 500 <= response_code AND response_code < 600,
total_count = COUNT(*)
```
We could translate the WHERE expression into an `ExpressionEvaluator`
and run it, then plug it into the filtering support added in this PR.
The actual filtering is done by creating a `FilteredAggregatorFunction`
which wraps a regular `AggregatorFunction` first executing the filter
against the incoming `Page` and then passing the resulting mask to the
`AggregatorFunction`. We've then added a `mask` to
`AggregatorFunction#process` which each aggregation function must use
for filtering.
We keep the unfiltered behavior by sending a constant block with `true`
in it. Each agg detects this and takes an "unfiltered" path, preserving
the original performance.
Importantly, when you don't turn this on it doesn't effect performance:
```
(blockType) (grouping) (op) Score Error -> Score Error Units
vector_longs none count 0.007 ± 0.001 -> 0.007 ± 0.001 ns/op
vector_longs none min 0.123 ± 0.004 -> 0.128 ± 0.005 ns/op
vector_longs longs count 4.311 ± 0.192 -> 4.218 ± 0.053 ns/op
vector_longs longs min 5.476 ± 0.077 -> 5.451 ± 0.074 ns/op
```
nik9000
added
:Analytics/ES|QL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.x: