Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trappy timeouts in downsample action #112734

Merged

Conversation

DaveCTurner
Copy link
Contributor

Relates #107984

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@@ -561,7 +561,13 @@ private Set<Index> waitForInProgressOrTriggerDownsampling(
* Issues a request downsample the source index to the downsample index for the specified round.
*/
private void downsampleIndexOnce(DataStreamLifecycle.Downsampling.Round round, String sourceIndex, String downsampleIndexName) {
DownsampleAction.Request request = new DownsampleAction.Request(sourceIndex, downsampleIndexName, null, round.config());
DownsampleAction.Request request = new DownsampleAction.Request(
TimeValue.THIRTY_SECONDS /* TODO should this be longer/configurable? */,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine at the moment...I will create an issue and discuss with my colleagues...downsampling requires time that is proportional to the number of documents to process...so maybe this timeout is better set based on that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ this is how it is today (this PR just makes the implicit default into an explicit choice). It'd be best if it were either (a) configurable by the user or (b) infinite, but I didn't want to make that change here. See the javadocs on org.elasticsearch.action.support.master.MasterNodeRequest#MasterNodeRequest(org.elasticsearch.core.TimeValue) for more info.

@salvatore-campagna
Copy link
Contributor

LGTM

@DaveCTurner DaveCTurner merged commit 2db52ae into elastic:main Sep 11, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the 2024/09/11/downsample-trappy-timeout branch September 11, 2024 12:18
davidkyle pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants