Code

[ESQL] Add SPACE function#112350

Code

Merged

chrisberkhout merged 25 commits intoelastic:mainelastic/elasticsearch:mainfrom chrisberkhout:esql-functions-spacechrisberkhout/elasticsearch:esql-functions-spaceCopy head branch name to clipboardSep 9, 2024

+573-6

Commits

Commits on Aug 29, 2024

• Initial implementation of SPACE() function.

  chrisberkhout

  committed
  6c961ad

• SpaceTests.java

  chrisberkhout

  committed
  6e6003c

• Add docs.

  chrisberkhout

  committed
  4c4fa12

• Remove warnExceptions parameter from the @evaluator for processConstant.

  Show description for 43eb5bc
  chrisberkhout

  committed
  43eb5bc

• Extract duplicate checks of number parameter range.

  chrisberkhout

  committed
  b47dc54

• Test and fix type resolution.

  chrisberkhout

  committed
  72350cf

• Add test for requesting space too large.

  chrisberkhout

  committed
  991dd76

• Improve example for documentation.

  chrisberkhout

  committed
  bb3bc07

• Revert "Improve example for documentation." (Doc doesn't render extra spaces in the result)

  Show description for 91f62b9
  chrisberkhout

  committed
  91f62b9

• Add new capability for function SPACE.

  chrisberkhout

  committed
  1f4ec7a

• Update docs/changelog/112350.yaml

  chrisberkhout

  committed
  d2a452c

• Fix style.

  chrisberkhout

  committed
  f76cf79

• Test with input from an index.

  chrisberkhout

  committed
  8ec8c6a

• Add serialization tests.

  chrisberkhout

  committed
  b1047ec

• Add more testing advice to the guide to adding a new function.

  chrisberkhout

  committed
  f804232

• Remove constant evaluator in favor of building a literal.

  chrisberkhout

  committed
  645730a

• Use field in the superclass rather than adding number.

  chrisberkhout

  committed
  0540423

Commits on Aug 30, 2024

• Fix test.

  chrisberkhout

  committed
  bd688ee

Commits on Aug 31, 2024

• Simplify test setup.

  chrisberkhout

  committed
  74ac4cc

• Bulk fill with Arrays.fill rather than a loop.

  chrisberkhout

  committed
  f7d6435

• Update description as suggested.

  chrisberkhout

  committed
  98e5cef

• Make Space.MAX_LENGTH private.

  chrisberkhout

  committed
  8a6c216

• Add more complex test.

  chrisberkhout

  committed
  d03fef3

• Return null and warnings for a multi-value parameter.

  chrisberkhout

  committed
  8e4f1c5

Commits on Sep 8, 2024

• Merge branch 'main' into esql-functions-space

  chrisberkhout

  authored
  0408b00