Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dimension fields to have multiple values in standard and logsdb index mode #112345

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Allow dimension fields to have multiple values in standard and logsdb index mode #112345

merged 7 commits into from
Sep 4, 2024

Conversation

felixbarny
Copy link
Member

Fixes #112232
Fixes #112239

@felixbarny felixbarny added the :StorageEngine/Mapping The storage related side of mappings label Aug 29, 2024
@felixbarny felixbarny requested a review from a team as a code owner August 29, 2024 12:15
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine added Team:StorageEngine v8.16.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @felixbarny, I've created a changelog YAML for you.

kkrik-es
kkrik-es approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for Martijn to take a look too, in case we missed something.

martijnvg
martijnvg approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one testing comment, LGTM otherwise.

server/src/test/java/org/elasticsearch/index/mapper/BooleanFieldMapperTests.java Outdated Show resolved Hide resolved
@felixbarny felixbarny added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 4, 2024
@carsonip carsonip mentioned this pull request Sep 4, 2024
Closed
@felixbarny
Copy link
Member Author

@elasticmachine test this please

@elasticsearchmachine elasticsearchmachine merged commit e1b4209 into elastic:main Sep 4, 2024
16 checks passed
@felixbarny felixbarny deleted the allow-array-dimensions-non-tsdb branch September 4, 2024 18:03
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
@felixbarny @cbuescher
Allow dimension fields to have multiple values in standard and logsdb…
1f95d4b 
… index mode (elastic#112345)

Fixes elastic#112232 Fixes
elastic#112239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg approved these changes

@kkrik-es kkrik-es kkrik-es approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v8.16.0
Projects
None yet
Milestone
No milestone
4 participants
@felixbarny @elasticsearchmachine @martijnvg @kkrik-es