Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Rewrite "What is Elasticsearch?" (Part 1) #112213

Merged
merged 15 commits into from
Aug 29, 2024

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Aug 26, 2024

Part 1: Focus on practical info: high-level overview of deployment, use cases, helpful links. Remove outdated and messy content.

Consider all links as placeholders and please suggest alternatives.

URL preview ✨

TODO

  • Use attributes for URLs

Follow up work for this page

Coming in future PRs:

  • Rewrite indices and shard/scalability info. (In a How Elasticsearch works? subpage perhaps). Explain indices, fields, and all the under-the-hood goodness. Use a new asciidoc file for legibility instead of chunking single source page into multiple HTML pages.
  • Move Elastic Stack overview from different book into this section as subpage
  • Create a concise features overview as subpage (optional)

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Aug 26, 2024
@leemthompo leemthompo added >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Aug 26, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Aug 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw this PR and wanted to read it immediately. It's great and very exciting! Sorry, left a couple of minor suggestions mostly about using attributes more consistently – hope that's okay. Please take or leave them!

docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/modules/shard-ops.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: István Zoltán Szabó <[email protected]>
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is infinitely better!

left a lot of thoughts but not all of them need to be addressed right now. however, I am concerned about removing content in this PR without a replacement.

docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
=== Deployment options

To use {es}, you need a running instance of the {es} service.
You can deploy {es} in various ways:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we clearer "some of these cost money and some of these are free" messaging. ECE and ECK are especially confusing in comparison to self-managed. can also be a follow-up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to just list the options and let devs decide. Free trials imply paid services. And honestly I don't think anyone "gets started" with ES by using ECE or ECK. I like concision here and we have links to learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could categorize self-managed, ECE, and ECK into an "advanced deployment" options section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would work for me, although self-managed is also the beginner/builder path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's why local dev has its own category and has top billing 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad

docs/reference/intro.asciidoc Show resolved Hide resolved
docs/reference/intro.asciidoc Show resolved Hide resolved
docs/reference/intro.asciidoc Show resolved Hide resolved
Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small comments for now -- going to do a more complete review tomorrow.

docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go from my perspective (after link fixes)?

++++
<titleabbrev>Scalability and resilience</titleabbrev>
++++
=== Scalability and resilience
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these headings are so much better ty

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much clearer. Not sure why I'm obsessed with hyphens this week -- feel free to ignore me, because the substantive stuff is already so much better with your revisions. 🥇

@@ -2,7 +2,7 @@

[[near-real-time]]
=== Near real-time search
The overview of <<documents-indices,documents and indices>> indicates that when a document is stored in {es}, it is indexed and fully searchable in _near real-time_--within 1 second. What defines near real-time search?
When a document is stored in {es}, it is indexed and fully searchable in _near real-time_--within 1 second. What defines near real-time search?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now realizing we often have a hyphen in the noun form (there's one here, _near real-time_), and arguably we'd need to add one to "near-real-time search" if we're being picky, which isn't worth it.

So it'd be fair to undo that other change I suggested, and just standardize on the hyphenated form for simplicity and readability.

docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
++++
<titleabbrev>Scalability and resilience</titleabbrev>
++++
=== Scalability and resilience
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
docs/reference/intro.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: marciw <[email protected]>
@leemthompo leemthompo merged commit aa57a15 into elastic:main Aug 29, 2024
5 checks passed
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Aug 29, 2024
@leemthompo
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.15
8.14

Questions ?

Please refer to the Backport tool documentation

leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Aug 29, 2024
leemthompo added a commit that referenced this pull request Aug 29, 2024
leemthompo added a commit that referenced this pull request Aug 29, 2024
dakrone pushed a commit to dakrone/elasticsearch that referenced this pull request Aug 30, 2024
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v8.14.0 v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants