-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Rewrite "What is Elasticsearch?" (Part 1) #112213
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw this PR and wanted to read it immediately. It's great and very exciting! Sorry, left a couple of minor suggestions mostly about using attributes more consistently – hope that's okay. Please take or leave them!
Co-authored-by: István Zoltán Szabó <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is infinitely better!
left a lot of thoughts but not all of them need to be addressed right now. however, I am concerned about removing content in this PR without a replacement.
=== Deployment options | ||
|
||
To use {es}, you need a running instance of the {es} service. | ||
You can deploy {es} in various ways: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we clearer "some of these cost money and some of these are free" messaging. ECE and ECK are especially confusing in comparison to self-managed. can also be a follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's OK to just list the options and let devs decide. Free trials imply paid services. And honestly I don't think anyone "gets started" with ES by using ECE or ECK. I like concision here and we have links to learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could categorize self-managed, ECE, and ECK into an "advanced deployment" options section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would work for me, although self-managed is also the beginner/builder path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's why local dev has its own category and has top billing 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah my bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small comments for now -- going to do a more complete review tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go from my perspective (after link fixes)?
++++ | ||
<titleabbrev>Scalability and resilience</titleabbrev> | ||
++++ | ||
=== Scalability and resilience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these headings are so much better ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much clearer. Not sure why I'm obsessed with hyphens this week -- feel free to ignore me, because the substantive stuff is already so much better with your revisions. 🥇
@@ -2,7 +2,7 @@ | |||
|
|||
[[near-real-time]] | |||
=== Near real-time search | |||
The overview of <<documents-indices,documents and indices>> indicates that when a document is stored in {es}, it is indexed and fully searchable in _near real-time_--within 1 second. What defines near real-time search? | |||
When a document is stored in {es}, it is indexed and fully searchable in _near real-time_--within 1 second. What defines near real-time search? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm now realizing we often have a hyphen in the noun form (there's one here, _near real-time_
), and arguably we'd need to add one to "near-real-time search" if we're being picky, which isn't worth it.
So it'd be fair to undo that other change I suggested, and just standardize on the hyphenated form for simplicity and readability.
++++ | ||
<titleabbrev>Scalability and resilience</titleabbrev> | ||
++++ | ||
=== Scalability and resilience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-authored-by: marciw <[email protected]>
(cherry picked from commit aa57a15)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit aa57a15)
Part 1: Focus on practical info: high-level overview of deployment, use cases, helpful links. Remove outdated and messy content.
Consider all links as placeholders and please suggest alternatives.
URL preview ✨
TODO
Follow up work for this page
Coming in future PRs: