Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional BlobCacheMetrics, expose BlobCacheMetrics via SharedBlobCacheService #111730

Merged
merged 36 commits into from
Aug 15, 2024
Merged

Add additional BlobCacheMetrics, expose BlobCacheMetrics via SharedBlobCacheService #111730

merged 36 commits into from
Aug 15, 2024

Commits on Aug 9, 2024

  1. Add callback for copy-to-cache metrics, additional BlobCacheMetrics 

    Relates: ES-9067
    @nicktindall
    nicktindall committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5dacb69 View commit details
    Browse the repository at this point in the history

  2. Update docs/changelog/111730.yaml

    @nicktindall
    nicktindall committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c4b6487 View commit details
    Browse the repository at this point in the history

  3. Shorten metric names (exceeded max length)

    @nicktindall
    nicktindall committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ad68e99 View commit details
    Browse the repository at this point in the history

  4. Align attribute key name

    @nicktindall
    nicktindall committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    181b958 View commit details
    Browse the repository at this point in the history

  5. Remove callback from method not used by stateless

    @nicktindall
    nicktindall committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    07dfc5a View commit details
    Browse the repository at this point in the history

  6. Add CachePopulationReason.CacheMiss

    @nicktindall
    nicktindall committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9c8ee42 View commit details
    Browse the repository at this point in the history

  7. Revert "Remove callback from method not used by stateless" 

    This reverts commit 07dfc5a.
    @nicktindall
    nicktindall committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    752b1ef View commit details
    Browse the repository at this point in the history

  8. NO_OP -> NOOP

    @nicktindall
    nicktindall committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c0189f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Remove metrics from copyToCacheFileAligned not used

    @nicktindall
    nicktindall committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    7c34720 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feature/ES-9067_expos… 

    …e_cache_copy_metrics
    @nicktindall
    nicktindall committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    69d58ec View commit details
    Browse the repository at this point in the history

  3. Add todo

    @nicktindall
    nicktindall committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    c823f75 View commit details
    Browse the repository at this point in the history

  4. Protect against divide-by-zero

    @nicktindall
    nicktindall committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    10a32f6 View commit details
    Browse the repository at this point in the history

  5. Remove unused CachePopulationReason#LoadCommit

    @nicktindall
    nicktindall committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    439152c View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge branch 'main' into feature/ES-9067_expose_cache_copy_metrics

    @nicktindall
    nicktindall committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f8dfabc View commit details
    Browse the repository at this point in the history

  2. Simplify blob-cache population notifications, extract interface

    @nicktindall
    nicktindall committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5c38dbf View commit details
    Browse the repository at this point in the history

  3. Add time/bytes counter, make throughput MB/s

    @nicktindall
    nicktindall committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d504094 View commit details
    Browse the repository at this point in the history

  4. Fix metric names

    @nicktindall
    nicktindall committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c8e6d28 View commit details
    Browse the repository at this point in the history

  5. Fix javadocs

    @nicktindall
    nicktindall committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    03a8f1d View commit details
    Browse the repository at this point in the history

  6. Be more defensive when handling metrics

    @nicktindall
    nicktindall committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    47a0a35 View commit details
    Browse the repository at this point in the history

  7. Don't notify when no bytes were copied

    @nicktindall
    nicktindall committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a71d70b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Add test for SharedBytes#copyToCacheFileAligned

    @nicktindall
    nicktindall committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    95d2e5f View commit details
    Browse the repository at this point in the history

  2. Fix comment, ensure room for at least a byte

    @nicktindall
    nicktindall committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e18a283 View commit details
    Browse the repository at this point in the history

  3. Use strings for metric values

    @nicktindall
    nicktindall committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    168efe1 View commit details
    Browse the repository at this point in the history

  4. Take shard ID as a string, to reduce string concatenation

    @nicktindall
    nicktindall committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f60d341 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Remove BlobCachePopulationListener

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c938e89 View commit details
    Browse the repository at this point in the history

  2. Add source to BlobCacheMetrics

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8f5967a View commit details
    Browse the repository at this point in the history

  3. Add test, extract CachePopulationSource

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    45fb734 View commit details
    Browse the repository at this point in the history

  4. Expose BlobCacheMetrics from SharedBlobCacheService

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    71c0b2c View commit details
    Browse the repository at this point in the history

  5. Fix test name

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    91405f2 View commit details
    Browse the repository at this point in the history

  6. Delete docs/changelog/111730.yaml

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    03a0140 View commit details
    Browse the repository at this point in the history

  7. Improve metric and attribute names

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    df97c59 View commit details
    Browse the repository at this point in the history

  8. Randomise BlobCacheMetricsTests

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8295d35 View commit details
    Browse the repository at this point in the history

  9. De-duplicate

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a903534 View commit details
    Browse the repository at this point in the history

  10. Fix spotless

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e8edc63 View commit details
    Browse the repository at this point in the history

  11. Add Unknown CachePopulationSource

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    81e2776 View commit details
    Browse the repository at this point in the history

  12. Apply feedback

    @nicktindall
    nicktindall committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b17f316 View commit details
    Browse the repository at this point in the history