Clean the last traces from global retention in templates #111669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
@elasticmachine update branch |
masseyke
reviewed
Aug 8, 2024
| } | ||
| Map<String, ComposableIndexTemplate> templates = new HashMap<>(); | ||
| for (int i = 0; i < randomIntBetween(1, 4); i++) { | ||
| templates.put(randomAlphaOfLength(4), ComposableIndexTemplateTests.randomInstance()); | ||
| } | ||
| return new GetComposableIndexTemplateAction.Response(templates, globalRetention); | ||
| return new GetComposableIndexTemplateAction.Response(templates, rolloverConfiguration); | ||
| } | ||
|
|
||
| @Override | ||
| protected GetComposableIndexTemplateAction.Response mutateInstance(GetComposableIndexTemplateAction.Response instance) { | ||
| return randomValueOtherThan(instance, this::createTestInstance); |
There was a problem hiding this comment.
Just a note -- this kind of mutateInstance seems to defeat the purpose of the test, but that's outside of the scope of this PR.
There was a problem hiding this comment.
Happy to implement since I am in the code :)
masseyke
approved these changes
Aug 8, 2024
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Aug 19, 2024
* upstream/main: Fail `indexDocs()` on rejection (elastic#111962) Move repo analyzer to its own package (elastic#111963) Add generated evaluators for DateNanos conversion functions (elastic#111961) Clean the last traces from global retention in templates (elastic#111669) Fix known issue docs for elastic#111866 (elastic#111956) x-pack/plugin/otel: introduce x-pack-otel plugin (elastic#111091) Improve reaction to blob store corruptions (elastic#111954) Introduce `StreamingXContentResponse` (elastic#111933) Revert "Add 8.15.0 known issue for memory locking in Windows (elastic#111949)" Test get-snapshots API with missing details (elastic#111903) Add 8.15.0 known issue for memory locking in Windows (elastic#111949) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #108170.
In this PR we remove completely the global retention field from the templates. We left some deprecated constructors because they are still used in serverless. We will clean them up in a follow up PR.