Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14] Remove version barrier for synthetic version based features in tests #110709

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[8.14] Remove version barrier for synthetic version based features in tests #110709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestFeatureService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,6 @@ public boolean clusterHasFeature(String featureId) {
Matcher matcher = VERSION_FEATURE_PATTERN.matcher(featureId);
if (matcher.matches()) {
Version extractedVersion = Version.fromString(matcher.group(1));
if (Version.CURRENT.before(extractedVersion)) {
// As of version 8.14.0 REST tests have been migrated to use features only.
// For migration purposes we provide a synthetic version feature gte_vX.Y.Z for any version at or before CURRENT (8.14.x).
throw new IllegalArgumentException(
Strings.format(
"Synthetic version features are only available before [%s] for migration purposes! "
+ "Please add a cluster feature to an appropriate FeatureSpecification; test-only historical-features "
+ "can be supplied via ESRestTestCase#createAdditionalFeatureSpecifications()",
Version.CURRENT
)
);
}
return version.onOrAfter(extractedVersion);
}

Expand Down