Improve refcounting in testClientCancellation
#110309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes in elastic#109519 we now do one more async step while serving the response, so we need to acquire another ref to track the new step. Relates elastic#109866 Relates elastic#110118 Relates elastic#110175 Relates elastic#110249
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
…sIT-testClientCancellation
nicktindall
reviewed
Jun 30, 2024
| final var latch = new CountDownLatch(1); | ||
| refs = LeakTracker.wrap(reachabilityChecker.register(AbstractRefCounted.of(latch::countDown))); | ||
| refs = AbstractRefCounted.of(latch::countDown); |
There was a problem hiding this comment.
Are you sure it's not worth leaving the leak tracking in? it did make it much easier to troubleshoot.
There was a problem hiding this comment.
I'm not sure, no, although I'd generally rather keep debug stuff out of tests while they're not known to be flaky. If we keep having problems here then we can put it back easily enough.
nicktindall
approved these changes
Jun 30, 2024
DaveCTurner
deleted the
2024/06/30/improve-Netty4ChunkedContinuationsIT-testClientCancellation
branch
|
Post-merge LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes in #109519 we now do one more async step while serving
the response, so we need to acquire another ref to track the new step.
Relates #109866
Relates #110118
Relates #110175
Relates #110249