Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some docs explaining filter performance and behavior for HNSW #110108

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

benwtrent
Copy link
Member

We should explain how HNSW can be slower with filtering and that there are two mitigations in place to address this.

This is not meant to be exhaustive with benchmarks, etc. I think a larger blog post is warranted for overall performance with filtering and explaining how HNSW graph exploration is effected.

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Jun 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@benwtrent
Copy link
Member Author

Backporting to 8.4 as that is when knn was GA'd

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks Ben!

@benwtrent benwtrent merged commit 1c1733d into elastic:main Jun 25, 2024
6 checks passed
@benwtrent benwtrent deleted the docs/add-some-knn-filtering-docs branch June 25, 2024 12:42
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.4
8.5
8.6
8.7
8.8
8.9
8.10
8.11
8.12
8.13
8.14

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants