Add getAndSet to some BigArray implementations and make set return void #109878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of callsites for these things don't look at the return. Computing the return from bytes to numeric values is not free due to bounds checks etc. => this PR adds a set that doesn't read the previous value and where needed moves the existing code to a new getAndSet call
original-brownbear
added
>non-issue
:Analytics/Aggregations
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nik9000
approved these changes
Jun 19, 2024
|
Thanks you two! |
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of callsites for these things don't look at the return. Computing the return from bytes to numeric values is not free due to bounds checks etc.
=> this PR adds a set that doesn't read the previous value and where needed moves the existing code to a new getAndSet call