-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect latest changes in synthetic source documentation #109501
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ad8d7cc
Reflect latest changes in synthetic source documentation
lkts d426e2f
Merge branch 'main' into rework_synthetic_source_docs
elasticmachine dd16e84
iter
lkts 4f79ae6
Update docs/changelog/109501.yaml
lkts 3ae3480
Add a release highlight
lkts 6b417e7
Fix changelog
lkts ccd889c
iter
lkts 873bb35
Update docs/reference/mapping/fields/synthetic-source.asciidoc
lkts 42af247
Update docs/reference/mapping/fields/synthetic-source.asciidoc
lkts 64822ca
Update docs/reference/mapping/fields/synthetic-source.asciidoc
lkts 4a234ae
Update docs/reference/mapping/fields/synthetic-source.asciidoc
lkts 18732e4
Update docs/reference/mapping/fields/synthetic-source.asciidoc
lkts a475445
iter
lkts 32e80d3
Update docs/changelog/109501.yaml
lkts 6e95674
Revert "Update docs/changelog/109501.yaml"
lkts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
pr: 109501 | ||
summary: Reflect latest changes in synthetic source documentation | ||
area: Mapping | ||
type: enhancement | ||
issues: [] | ||
highlight: | ||
title: Synthetic `_source` improvements | ||
body: |- | ||
There are multiple improvements to synthetic `_source` functionality: | ||
|
||
* Synthetic `_source` is now supported for all field types including `nested` and `object`. `object` fields are supported with `enabled` set to `false`. | ||
|
||
* Synthetic `_source` can be enabled together with `ignore_malformed` and `ignore_above` parameters for all field types that support them. | ||
notable: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence on whether to report the fields that have additional indexing overhead when
ignore_malformed
orignore_above
are set. Wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fair, i imagine normally you expect malformed values to be a small portion of your data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the copying parser always copies the current value preemptively, iiuc? This should increase overhead for all indexed docs, not just the ones with malformed values..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. I don't know if it should be in this section but we can mention it somewhere. Let me follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait with mentioning the copy parser overhead until we have a better understanding how much it actually is? I suspect it is minimal.