Harden field-caps request dispatcher #108736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @dnhatn, I've created a changelog YAML for you. |
nik9000
approved these changes
May 17, 2024
| assert removed != null; | ||
| onIndexFailure.accept(failedIndex, e); | ||
| } | ||
| } finally { |
There was a problem hiding this comment.
Wouldn't it make more sense to quietly record the individual index failure (so essentially catch/suppress inside the loop) instead of propagating a somewhat expected exception further?
|
@nik9000 @original-brownbear Thanks for reviewing. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
May 20, 2024
ExceptionHelper#useAndSuppress can throw exceptions if both input exceptions having the same root cause. If this happens, the field-caps request dispatcher might fail to notify the completion to the caller. I found this while running ES|QL with disruptions. Relates elastic#107347
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 20, 2024
ExceptionHelper#useAndSuppress can throw exceptions if both input exceptions having the same root cause. If this happens, the field-caps request dispatcher might fail to notify the completion to the caller. I found this while running ES|QL with disruptions. Relates #107347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExceptionHelper#useAndSuppresscan throw exceptions if both input exceptions having the same root cause. If this happens, the field-caps request dispatcher might fail to notify the completion to the caller. I found this while running ES|QL with disruptions.Relates #107347