Replace mocks with test implementation in RepositoriesServiceTests #108589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.15.0
needs:triage
mhl-b
changed the title
mhl-b
changed the title
mhl-b
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
May 14, 2024
DaveCTurner
approved these changes
May 14, 2024
Comment on lines
+102
to
+103
| // cluster utils publisher does not call AckListener, making some method calls hang indefinitely | ||
| // in this test we have a single master node, and it acknowledges cluster state immediately |
Comment on lines
319
to
320
| var resp = safeAwait(resultListener); | ||
| assertTrue(resp.isAcknowledged()); |
There was a problem hiding this comment.
nit: would rather not use abbrs. for var. names wherever poss. :)
Suggested change
| var resp = safeAwait(resultListener); | |
| assertTrue(resp.isAcknowledged()); | |
| var response = safeAwait(resultListener); | |
| assertTrue(response.isAcknowledged()); |
mhl-b
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that
testRegisterRepositorySuccessAfterCreationFailedtest never invokes assertion blocks, because listener is not invoked.There are 2 problems:
PutRepositories method relies on cluster state update. I replace mocked ClusterService and ThreadPool with test implementation of these. Also add blocking call on listener to ensure we get result.
Address comment to break down larger PR into smaller pieces in #108531