Add explicit plugin method for MappedActionFilter #108515
Conversation
In preparation for elastic#108210, this commit adds a separate method to gather MappedActionFilter instances. For now this remains compatible with the existing getActionFilters by allowing MappedActionFilter to exist in both places.
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
| @@ -807,6 +807,7 @@ private static ActionFilters setupActionFilters(List<ActionPlugin> actionPlugins | |||
| finalFilters.add(filter); | |||
| } | |||
| } | |||
| mappedFilters.addAll(plugin.getMappedActionFilters()); | |||
There was a problem hiding this comment.
Nit: maybe add a TODO/comment to remove the instanceof above?
There was a problem hiding this comment.
(Never mind, I just saw #108210)
| /** | ||
| * Action filters applying to a single action added by this plugin. | ||
| */ | ||
| default Collection<MappedActionFilter> getMappedActionFilters() { |
There was a problem hiding this comment.
A Q: plugins should migrate to this method to return a MappedActionFilter.
Would it be possible then to remove the ability to return a MappedActionFilter from getActionFilters()? I think it will be OK for modules and for serverless, but what about 3rd party? We do not guarantee any bwc there, correct? (They work only with the ES version they were compiled with, to the patch?)
There was a problem hiding this comment.
Plugins have zero backcompat guarantees (at least these classic plugins). After converting serverless to use MappedActionFilter I will followup with making MappedActionFilter no longer inherit from ActionFilter, so it will not be possible to return via getActionFilters().
rjernst
added
the
auto-merge-without-approval
In preparation for #108210, this commit adds a separate method to gather MappedActionFilter instances. For now this remains compatible with the existing getActionFilters by allowing MappedActionFilter to exist in both places.