-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document transport.compress
trade-offs more clearly
#108458
Document transport.compress
trade-offs more clearly
#108458
Conversation
Documentation preview: |
2de68ac
to
f9e28b9
Compare
Spells out explicitly that setting `transport.compress: true` may cost extra CPU.
f9e28b9
to
9d1338f
Compare
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
compression by to the `transport.compress` setting. Accepts either `deflate` or | ||
`lz4`, which offer different trade-offs between compression ratio and CPU | ||
usage. {es} will use the same compression scheme for responses as for the | ||
corresponding requests. If `lz4` is configured and the remote node has not been | ||
upgraded to a version supporting `lz4`, the traffic will be sent uncompressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LZ4 was added in V_7_14_0 which cannot communicate on non-handshake requests with current version nodes. So I don't think we need to document this fallback behavior anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right good point, I did wonder whether that was obsolete.
Spells out explicitly that setting `transport.compress: true` may cost extra CPU.
💔 Backport failed
You can use sqren/backport to manually backport by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Spells out explicitly that setting `transport.compress: true` may cost extra CPU.
Spells out explicitly that setting
transport.compress: true
may costextra CPU.