Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Reenable JdbcCsvSpecIT inWithCompatibleDateTypes #108017

Merged
merged 1 commit into from
May 7, 2024

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Apr 29, 2024

Reenable org.elasticsearch.xpack.sql.qa.single_node.JdbcCsvSpecIT "test {filter.testInWithCompatibleDateTypes}", no longer reproducible.

The test has been added in 2019 (#47595) and started failing mid-last year (disabled in #96805).
It no longer reproduces on any of the JDK17+. Will reenable, but keep the disabling issue open while monitoring.

Reenable org.elasticsearch.xpack.sql.qa.single_node.JdbcCsvSpecIT
"test {filter.testInWithCompatibleDateTypes}", no longer reproducible.
@bpintea bpintea added >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying v8.14.1 v8.15.0 labels Apr 29, 2024
@bpintea bpintea requested a review from astefan April 29, 2024 13:19
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit b6ded32 into elastic:main May 7, 2024
14 checks passed
@bpintea bpintea deleted the test/reenable_test_96805 branch May 7, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.14.1 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants