Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate MasterNodeRequest#masterNodeTimeout #107999

Merged

Conversation

DaveCTurner
Copy link
Contributor

There's no good reason for this field to have protected visibility,
and we definitely don't want subclasses to be able to set it to null.
This commit makes it private.

Relates #107984

There's no good reason for this field to have `protected` visibility,
and we definitely don't want subclasses to be able to set it to `null`.
This commit makes it `private`.

Relates elastic#107984
@DaveCTurner DaveCTurner added >non-issue :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.15.0 labels Apr 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Apr 29, 2024
@DaveCTurner DaveCTurner merged commit a2d9cc6 into elastic:main Apr 30, 2024
14 checks passed
@DaveCTurner DaveCTurner deleted the 2024/04/29/encapsulate-masterNodeTimeout branch April 30, 2024 06:39
@DaveCTurner DaveCTurner restored the 2024/04/29/encapsulate-masterNodeTimeout branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants