-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docs about scaled_float saturation with long values #107966
Adding docs about scaled_float saturation with long values #107966
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-search (Team:Search) |
However, the value actually stored is +9223372036854775807+, the maximum value for a `long`. | ||
|
||
This can lead to unexpected results with <<query-dsl-range-query,range queries>> | ||
when the scaling factor is large or the value is close to the maximum value of a `long`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unclear whether value
here is the scaled float or the original value before scaling. assume the former, so maybe we should say resulting scaled value
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted, what do you think? I mean the provided value, not the stored one. If the stored one is "near" the maximum, who cares, its all about when it exceeds the maximum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes more sense - thanks!
Co-authored-by: shainaraskas <[email protected]>
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
closes: #105361