Forbid null ack timeout
#107653
Merged
Forbid null ack timeout
#107653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today a cluster state update task with `null` ack timeout implies the timeout is zero. This implicit behaviour is trappy, so this commit forbids it. Relates elastic#107044
DaveCTurner
added
>non-issue
:Distributed Coordination/Cluster Coordination
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| @@ -706,6 +706,7 @@ private static class TaskAckListener { | |||
| public void onCommit(TimeValue commitTime) { | |||
| TimeValue ackTimeout = contextPreservingAckListener.ackTimeout(); | |||
| if (ackTimeout == null) { | |||
| assert false : "ackTimeout must always be present: " + contextPreservingAckListener; | |||
| ackTimeout = TimeValue.ZERO; | |||
There was a problem hiding this comment.
Should we forbid this when running without assertions as well?
There was a problem hiding this comment.
I'm inclined to leave the production behaviour alone, for now at least. It's hard to be certain we've covered all the possible null values here by static analysis alone.
idegtiarenko
approved these changes
Apr 22, 2024
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a cluster state update task with
nullack timeout implies thetimeout is zero. This implicit behaviour is trappy, so this commit
forbids it.
Relates #107044