Stop using ReleasableLock in o.e.c.cache.Cache to save O(10M) in heap #107555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a couple heap dumps that show the lock wrapper alone waste O(10M) in heap for these things. Also, I suspect the indirection does cost non-trivial performance here in some cases. => lets spend a couple more lines of code to save that overhead
original-brownbear
added
>non-issue
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
approved these changes
Apr 17, 2024
|
Thanks Simon! I wonder, should we maybe just do away with |
DaveCTurner
approved these changes
Apr 17, 2024
Yea lets do that asap, I can do it on the side today :) I'm starting to get the feeling the overhead here is more than my initial intuition suggested actually ... |
original-brownbear
added
the
auto-merge-without-approval
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 18, 2024
As discussed in elastic#107555 there's some overhead to the use of `ReleasableLock` and it's probably not a good idea using it on the hot(ish) path in this class.
original-brownbear
added a commit
that referenced
this pull request
Jul 2, 2024
As discussed in #107555 there's some overhead to the use of `ReleasableLock` and it's probably not a good idea using it on the hot(ish) path in this class.
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a couple heap dumps that show the lock wrapper alone waste O(10M) in heap for these things. Also, I suspect the indirection does cost non-trivial performance here in some cases.
=> lets spend a couple more lines of code to save that overhead