[feature/semantic-text] Add query and model compatibility tests #107256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
requested review from
jimczi and
Mikep86
and removed request for
a team
elasticsearchmachine
added
the
needs:triage
…antic-text-add-query-tests
jimczi
approved these changes
Apr 9, 2024
| - match: { hits.total.value: 2 } | ||
| - match: { hits.total.relation: eq } | ||
| - match: { hits.hits.0.inner_hits.dense_field\.inference\.chunks.hits.total.value: 2 } | ||
| - exists: hits.hits.0.inner_hits.dense_field\.inference\.chunks.hits.hits.0.fields.dense_field\.inference\.chunks.0.text |
There was a problem hiding this comment.
We should be able to match the exact text of the chunk?
| - match: { hits.total.value: 2 } | ||
| - match: { hits.total.relation: eq } | ||
| - match: { hits.hits.0.inner_hits.sparse_field\.inference\.chunks.hits.total.value: 2 } | ||
| - exists: hits.hits.0.inner_hits.sparse_field\.inference\.chunks.hits.hits.0.fields.sparse_field\.inference\.chunks.0.text |
carlosdelest
merged commit 4d24bf0
into
elastic:feature/semantic-text
13 of 14 checks passed
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add queries that showcase using nested queries for performing search without the need for
semantic_query.