Don't overwrite DataStream.rolloverOnWrite flag on failure store rollover
#107247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsbauman
added
>non-issue
:Data Management/Data streams
|
Pinging @elastic/es-data-management (Team:Data Management) |
gmarouli
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Thanks for following up on this @nielsbauman. Shall we add a test too? Like a unit test? Then we can be sure this won't be missed in the future :)
Hmm on the one hand, I'd say we should add a unit test like that for all cases then (which I think is a bit overkill). But, since this specific line/method/scenario is about rollover as well, I'm fine with adding one for this specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #107206.
Not backporting as failure store rollover has only been part of 8.14.0.