[Profiling] Divide into more packages #107201
Conversation
With this commit we split the Universal Profiling plugin into three packages: * `persistence` contains everything w.r.t index management * `rest` contains the REST API * `action` contains the transport API The `action` / `rest` structure follows the already established structure in the rest of the code base. We divide this plugin into multiple packages mainly because the different functionalities will be maintained by different teams in the future. This restructuring helps clarify boundaries.
danielmitterdorfer
added
>non-issue
:UniversalProfiling/Application
elasticsearchmachine
added
the
Team:obs-knowledge
|
Pinging @elastic/obs-knowledge-team (Team:obs-knowledge) |
| assertEquals(response.getTotalSamples(), 3L); | ||
|
|
||
| return response; | ||
| return new GetStackTracesResponse( |
There was a problem hiding this comment.
I did this because this would have required to make the internal builder class public. As this test focuses on the REST action, it is fine to just construct the response directly (as done in the other test method) and avoid adding a dependency on the builder class.
| private final String namePrefix; | ||
| private final int version; | ||
| private final String generation; | ||
| private final OnVersionBump onVersionBump; | ||
| private final List<Migration> migrations; | ||
|
|
||
| public static ProfilingIndex regular(String name, int version, OnVersionBump onVersionBump) { | ||
| static ProfilingIndex regular(String name, int version, OnVersionBump onVersionBump) { |
There was a problem hiding this comment.
While we needed to declare the class itself public, there is no need for code outside the persistence package to create new indices and hence we kept the factory methods package-private.
|
While the changeset appears large, it's almost entirely file renames and changed package name declarations. I have annotated the changes that I have considered non-obvious. |
With this commit we split the Universal Profiling plugin into three packages:
persistencecontains everything w.r.t index managementrestcontains the REST APIactioncontains the transport APIThe
action/reststructure follows the already established structure in the rest of the code base. We divide this plugin into multiple packages mainly because the different functionalities will be maintained by different teams in the future. This restructuring helps clarify boundaries.