Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce role description field #107088

Merged

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    248c615 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b540d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42dbaab View commit details
    Browse the repository at this point in the history
  4. Merge branch 'sa-add-role-description' of github.com:slobodanadamovic…

    …/elasticsearch into sa-add-role-description
    slobodanadamovic committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    ad6e48f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fca71bb View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    906d537 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ca60fb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b22fe9a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    546602f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    23d3396 View commit details
    Browse the repository at this point in the history
  5. Refactor role descriptor parsing

    The method for `RoleDescriptor` parsing is becoming more complex due to
    its usage being shared between API keys, file-based and native roles.
    In some cases we allow 2.X format, in others we disallow
    restrictions. Having a single method with multiple boolean flags that
    control inclusion/exclusion of fields is becoming hard to extend.
    This refactoring aims to allow easier introduction of new fields that
    should be conditionally supported in some cases but not others.
    One of such cases is introduction of `description` field that should only
    be supported for file-based and native roles but not for roles embedded
    in API keys.
    slobodanadamovic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    36a3e5c View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'main' of github.com:elastic/elasticsearch into sa-refac…

    …tor-role-parsing
    
    # Conflicts:
    #	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/FileRolesStore.java
    slobodanadamovic committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    621959b View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge branch 'sa-refactor-role-parsing' of github.com:slobodanadamovi…

    …c/elasticsearch into sa-add-role-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/action/role/PutRoleRequestBuilder.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authc/CrossClusterAccessSubjectInfo.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptor.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorsIntersection.java
    #	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorTests.java
    #	x-pack/plugin/security/src/internalClusterTest/java/org/elasticsearch/xpack/security/authc/ApiKeyIntegTests.java
    #	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/FileRolesStore.java
    #	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/NativeRolesStore.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/test/TestSecurityClient.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyServiceTests.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/permission/FieldPermissionsTests.java
    slobodanadamovic committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c3ebf46 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ce3baab View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/action/apikey/ApiKey.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/action/apikey/BulkUpdateApiKeyRequestTranslator.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/action/apikey/CreateApiKeyRequestBuilder.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/action/apikey/UpdateApiKeyRequestTranslator.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/action/role/PutRoleRequestBuilder.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authc/CrossClusterAccessSubjectInfo.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptor.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorsIntersection.java
    #	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/action/service/GetServiceAccountResponseTests.java
    #	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorTests.java
    #	x-pack/plugin/security/qa/security-trial/src/javaRestTest/java/org/elasticsearch/xpack/security/role/RoleWithRemoteIndicesPrivilegesRestIT.java
    #	x-pack/plugin/security/src/internalClusterTest/java/org/elasticsearch/xpack/security/authc/ApiKeyIntegTests.java
    #	x-pack/plugin/security/src/internalClusterTest/java/org/elasticsearch/xpack/security/authc/apikey/ApiKeySingleNodeTests.java
    #	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/ApiKeyService.java
    #	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/FileRolesStore.java
    #	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/NativeRolesStore.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/test/TestSecurityClient.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyServiceTests.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/permission/FieldPermissionsTests.java
    slobodanadamovic committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c2e5a36 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b2a9d7d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48b069f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c3ed4ba View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9dbcfaa View commit details
    Browse the repository at this point in the history
  6. spotless

    slobodanadamovic committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e74a90d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8da5db4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9437d19 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    082c0c1 View commit details
    Browse the repository at this point in the history
  2. fix npe

    slobodanadamovic committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ab65161 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83f66ba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    168fa09 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    59631a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9ab9409 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Add API key tests

    slobodanadamovic committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    eaeeaf8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ba46b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef744de View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8b8bf29 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2974c61 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2dc0203 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4b41525 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    38556c8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    526d4be View commit details
    Browse the repository at this point in the history
  10. add bwc tests

    slobodanadamovic committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6e2e69d View commit details
    Browse the repository at this point in the history
  11. fix bwc test

    slobodanadamovic committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a18bff8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    da76594 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Add YAML test

    slobodanadamovic committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    825c840 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4de6d35 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7259f4d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc51317 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d4bd948 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dd893a2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    113d83f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    72bbd76 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6aa7c12 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    9368be1 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e04e992 View commit details
    Browse the repository at this point in the history
  3. Fix failing tests

    slobodanadamovic committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    05aa831 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    35a80dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1fb938a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be602ab View commit details
    Browse the repository at this point in the history
  4. remove comment

    slobodanadamovic committed May 6, 2024
    Configuration menu
    Copy the full SHA
    491b410 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    52fd232 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/action/role/PutRoleRequest.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptor.java
    #	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStore.java
    #	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/action/apikey/BulkUpdateApiKeyRequestTests.java
    #	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/action/apikey/CreateApiKeyRequestTests.java
    #	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/action/apikey/UpdateApiKeyRequestTests.java
    #	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorTests.java
    #	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/permission/SimpleRoleTests.java
    #	x-pack/plugin/security/qa/security-trial/src/javaRestTest/java/org/elasticsearch/xpack/security/apikey/ApiKeyRestIT.java
    #	x-pack/plugin/security/qa/security-trial/src/javaRestTest/java/org/elasticsearch/xpack/security/crossclusteraccess/CrossClusterAccessHeadersForCcsRestIT.java
    #	x-pack/plugin/security/src/internalClusterTest/java/org/elasticsearch/xpack/security/authc/ApiKeyIntegTests.java
    #	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/ApiKeyService.java
    #	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/NativeRolesStore.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyServiceTests.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/AuthorizationServiceIntegTests.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/RBACEngineTests.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStoreTests.java
    #	x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/store/NativeRolesStoreTests.java
    #	x-pack/plugin/security/src/test/resources/org/elasticsearch/xpack/security/authz/store/roles.yml
    #	x-pack/qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/ApiKeyBackwardsCompatibilityIT.java
    slobodanadamovic committed May 7, 2024
    Configuration menu
    Copy the full SHA
    619e335 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    981bec3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e20ca64 View commit details
    Browse the repository at this point in the history
  5. Fix failing test

    slobodanadamovic committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5ceb492 View commit details
    Browse the repository at this point in the history
  6. Another test fix

    slobodanadamovic committed May 7, 2024
    Configuration menu
    Copy the full SHA
    981b203 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4507041 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'main' of github.com:elastic/elasticsearch into sa-add-r…

    …ole-description
    
    # Conflicts:
    #	server/src/main/java/org/elasticsearch/TransportVersions.java
    slobodanadamovic committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e768c8b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0c56fef View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Fix toString test

    slobodanadamovic committed May 8, 2024
    Configuration menu
    Copy the full SHA
    990d9c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91ccbfb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a5c379 View commit details
    Browse the repository at this point in the history