Expanding and refactoring the vector rolling upgrade tests #107020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/es-search (Team:Search) |
pmpailis
reviewed
Apr 8, 2024
qa/rolling-upgrade/src/javaRestTest/java/org/elasticsearch/upgrades/VectorSearchIT.java
Show resolved
Hide resolved
| "Float vector search is not supported on this version", | ||
| getOldClusterTestVersion().onOrAfter(FLOAT_VECTOR_SEARCH_VERSION) | ||
| ); | ||
| if (isOldCluster()) { |
There was a problem hiding this comment.
One silly question as I'm not really familiar with this new framework. Will this be invoked during all steps in a strict order (old cluster / mixed / upgraded) so with this check here we ensure that the index creation will only run once?
| "type": "dense_vector", | ||
| "dims": 3, | ||
| "element_type": "byte", | ||
| "index": true, |
There was a problem hiding this comment.
Should we also add a byte-flat test case?
| response = search(searchRequest); | ||
| assertThat(extractValue(response, "hits.total.value"), equalTo(2)); | ||
| hits = extractValue(response, "hits.hits"); | ||
| assertThat(hits.get(0).get("_id"), equalTo("2")); |
There was a problem hiding this comment.
Maybe it'd be useful to add a small comment on why the first result is different and/or set explicit similarity (as that could be subject to change in-between releases) ? Or do we want to use the defaults ?
qa/rolling-upgrade/src/javaRestTest/java/org/elasticsearch/upgrades/VectorSearchIT.java
Show resolved
Hide resolved
|
Thanks @benwtrent ! Added some comments, mostly for my understanding! :) |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the legacy yaml rolling upgrade tests for vectors to the new rolling upgrade package.
Also, it adds rolling upgrade tests for
int8_hnsw.