Verify feature usage in REST tests #106800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus, fix logic to detect if a feature is "off" or "non-existing" (wrong, non-existing id). This works only for non-legacy tests, otherwise we log a warning and skip the check.
mosche
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine test this please |
ldematte
reviewed
Mar 27, 2024
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestFeatureService.java
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestFeatureService.java
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestFeatureService.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestFeatureService.java
Show resolved
Hide resolved
...test/java/org/elasticsearch/extractor/features/HistoricalFeaturesMetadataExtractorTests.java
Outdated
Show resolved
Hide resolved
|
Still looking into the ESQL test failures, but this is already proving valuable. First case of a misspelled feature: - cluster_features: esql.value_agg
+ cluster_features: esql.agg_values
reason: "values is available in 8.14+" |
mosche
commented
Mar 27, 2024
| @@ -364,22 +361,16 @@ protected final TestFeatureService createTestFeatureService( | |||
| Map<String, Set<String>> clusterStateFeatures, | |||
| Set<Version> semanticNodeVersions | |||
| ) { | |||
| // Historical features information is unavailable when using legacy test plugins | |||
| boolean hasHistoricalFeaturesInformation = System.getProperty("tests.features.metadata.path") != null; | |||
|
|
|||
| final List<FeatureSpecification> featureSpecifications = new ArrayList<>(createAdditionalFeatureSpecifications()); | |||
| featureSpecifications.add(new RestTestLegacyFeatures()); | |||
There was a problem hiding this comment.
@ldematte Do you know if there's a reason why RestTestLegacyFeatures aren't provided via createAdditionalFeatureSpecifications as done for YamlTestLegacyFeatures?
There was a problem hiding this comment.
Very simple: RestTestLegacyFeatures predates createAdditionalFeatureSpecifications.
If you feel like it, you can refactor it (but it's very minor IMO)
|
@elasticmachine update branch |
ldematte
approved these changes
Mar 28, 2024
thecoop
reviewed
Mar 28, 2024
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestFeatureService.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Mar 28, 2024
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestFeatureService.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Mar 28, 2024
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestFeatureService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particularly in YAML Rest tests it's easy to misspell feature names causing a test to never run and actually look healthy.
This change picks up earlier work (#104257) of @ldematte to fail if a feature is unknown based on the very latest features extracted from code.