Fix duplicate TSDB _source mappers #106792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tsdb source mappers now have a defined `Mode` by default so the deduplcation logic in the builder needs some adjustment. Found this in an SDH heap dump that had thousands of duplicate source field mappers in it all of a sudden. Also, we can save a little here (thought it only matters for non-default versions of this now) by using the empty string array constant for include and exclude list.
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
npnp Martijn! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tsdb source mappers now have a defined
Modeby default so the deduplcation logic in the builder needs some adjustment. Found this in an SDH heap dump that had thousands of duplicate source field mappers in it all of a sudden. Also, we can save a little here (thought it only matters for non-default versions of this now) by using the empty string array constant for include and exclude list.