[feature/semantic-text] Simplify the integration of the field inference metadata in IndexMetadata
#106743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver (elastic#105012)" This reverts commit f4d3ab9.
…copy-to-support-inference # Conflicts: # server/src/main/java/org/elasticsearch/action/bulk/BulkShardRequestInferenceProvider.java # server/src/test/java/org/elasticsearch/action/bulk/BulkOperationTests.java
…-fields in the mapping
…instead of re-creating them each time.
…gister_semantic_text
…ference_metadata_diff
jimczi
added
the
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
carlosdelest
approved these changes
Mar 26, 2024
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/InferenceFieldMetadata.java
Show resolved
Hide resolved
| if (item.request() instanceof IndexRequest ir) { | ||
| indexRequest = ir; | ||
| } else if (item.request() instanceof UpdateRequest updateRequest) { | ||
| if (updateRequest.script() != null) { |
There was a problem hiding this comment.
Good catch, the update could be a script and not a doc. Thanks for fixing this
| } | ||
| indexRequest = updateRequest.doc(); | ||
| } else { | ||
| // ignore delete request |
| @@ -119,6 +130,11 @@ public NestedObjectMapper getSubMappers() { | |||
| return subMappers; | |||
| } | |||
|
|
|||
| @Override | |||
| public InferenceFieldMetadata getMetadata(Set<String> sourcePaths) { | |||
There was a problem hiding this comment.
Nice - we use the same structure for retrieving metadata directly from the field type
| index: test-sparse-index | ||
| body: | ||
| - '{"update": {"_id": "doc_1"}}' | ||
| - '{"doc":{"inference_field": "I am a test", "another_inference_field": "I am a teapot"}}' |
There was a problem hiding this comment.
"I am a teapot"
HTTP 418 FTW 🤣
…ference_metadata_diff
…ference_metadata_diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the integration of the field inference metadata in
IndexMetadata. Instead of partial diffs, the new class simply sends the entire object as diff if it has changed.This PR also rename the fields and methods related to the inference fields consistently.
The inference phase (in the transport shard bulk action) is also changed so that inference is not called if:
If the document contains no value for the inference input but an inference result for that field, it is marked as failed.