Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/semantic-text] semantic text copy to support #106689
[feature/semantic-text] semantic text copy to support #106689
Changes from 29 commits
7aaa3b6
ebc26d2
86ddc9d
dd73d01
c5de0da
cf62b1b
f029015
d3f9d86
140caa3
7d1c92a
e023a19
05aa06f
c80677f
5896c60
df0cc90
6d4bbf3
068615a
5c3d9c4
ace17dd
8bebb8d
47a22d7
5311424
707b3f1
5e5b32a
1abf95c
29dd33e
b17d584
82ffb5b
6b26200
bf5b837
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this check for disallowing updates that do not use all source fields. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, except for one edge case: Say that a user wants to use an update request to delete a field from a document. Traditionally, they would do this by explicitly setting the field value to
null
. How do we tell the difference between thenull
we get when the user didn't set a value and thenull
we get when the user explicitly set it?IMO since we have a way to support partial updates in the near future (chunk source attribution), we could just live with this edge case for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple inference results can be applied to a single field from each source field - so we need to be prepared for that