Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code after previous refactorings #10666

Merged
merged 1 commit into from
Apr 20, 2015

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Apr 19, 2015

This is mostly removing code that handled deletion of types, which was
removed in #8877.

@rjernst rjernst added v2.0.0-beta1 :Search Foundations/Mapping Index mappings, including merging and defining field types and removed in progress labels Apr 19, 2015
@rjernst rjernst force-pushed the fix/mappings-dead-code branch from 554182e to 89860df Compare April 20, 2015 00:56
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Apr 20, 2015
This is mostly removing code that handled deletion of types, which was
removed in elastic#8877.

closes elastic#10666
@rjernst rjernst force-pushed the fix/mappings-dead-code branch from 89860df to ba6a0c1 Compare April 20, 2015 01:51
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Apr 20, 2015
This is mostly removing code that handled deletion of types, which was
removed in elastic#8877.

closes elastic#10666
@rjernst
Copy link
Member Author

rjernst commented Apr 20, 2015

I also cleaned up a some tests calling smartName, to reduce how many things rely on the Mappers (plural).

@jpountz
Copy link
Contributor

jpountz commented Apr 20, 2015

LGTM

This is mostly removing code that handled deletion of types, which was
removed in elastic#8877.

closes elastic#10666
@rjernst rjernst force-pushed the fix/mappings-dead-code branch from ba6a0c1 to 3a04d3c Compare April 20, 2015 17:07
@rjernst rjernst merged commit 3a04d3c into elastic:master Apr 20, 2015
@clintongormley clintongormley changed the title Mappings: Remove dead code after previous refactorings Remove dead code after previous refactorings Jun 8, 2015
@rjernst rjernst deleted the fix/mappings-dead-code branch September 18, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants