-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DownsampleMetrics #106632
Add DownsampleMetrics #106632
Conversation
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Another option is to return (inject) the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I thought we have some sort of a unit test infrastructure that we can use for metrics. @salvatore-campagna do you remember?
https://github.com/elastic/elasticsearch/blob/main/modules/apm/METERING.md#testing says we use |
Ok, I see. And this is already tested in the changes to the unit test in this pr. |
A single instance gets created by the
Downsample
plugin and injected to related actions.