[Transform] Fix _reset API when called with force=true on a failed transform
#106574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @przemekwitek, I've created a changelog YAML for you. |
|
Hi @przemekwitek, I've updated the changelog YAML for you. |
przemekwitek
changed the title
_reset API when called with force=true_reset API when called with force=true on a failed transform
💚 Backport successful
|
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Mar 21, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 21, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of
_resetAPI states:Unfortunately, for a failed transform this is not true. The
forceparameter does not do anything and the_resetAPI fails anyway.This PR fixes this by passing the value of
forceparameter from_resetrequest to_stoprequest.Additionally, this PR moves the
getTransformTasks()method to a commonTransformRestTestCaseclass from where it can be used by multiple tests.Fixes #106573