Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Fix CSV tests #106506

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 19, 2024

When we use ROW in ESQL we pick a random data set by just iterating the Map. It's random. Yay! And some of them don't work in this place. This just picks one that we know works.

Closes #106501

When we use `ROW` in ESQL we pick a random data set by just iterating
the `Map`. It's random. Yay! And some of them don't work in this place.
This just picks one that we know works.

Closes elastic#106501
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Analytics/ES|QL AKA ESQL v8.14.0 labels Mar 19, 2024
@nik9000 nik9000 requested a review from craigtaverner March 19, 2024 19:11
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 19, 2024
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000
Copy link
Member Author

nik9000 commented Mar 19, 2024

run elasticsearch-ci/8.12.3 / bwc-snapshots

@elasticsearchmachine elasticsearchmachine merged commit ea1672b into elastic:main Mar 19, 2024
14 checks passed
@nik9000 nik9000 deleted the esql_test_comeback branch March 19, 2024 20:53
@craigtaverner
Copy link
Contributor

Wow! I tried to figure this out before dinner, and failed. Fantastic that you fixed this! It was a mystery to me!

@nik9000
Copy link
Member Author

nik9000 commented Mar 19, 2024

It was so weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESQL CSVTests failing
4 participants